[vlc-commits] notify: Fix potential leak

Hugo Beauzée-Luyssen git at videolan.org
Thu May 31 10:26:31 CEST 2018


vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Thu May 31 10:15:26 2018 +0200| [2fea8197e1df02765a7f93acfe872d1607d2e0ec] | committer: Hugo Beauzée-Luyssen

notify: Fix potential leak

CID #1398419

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2fea8197e1df02765a7f93acfe872d1607d2e0ec
---

 modules/notify/notify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/notify/notify.c b/modules/notify/notify.c
index 3bf8c6dd9f..eecf36ad2b 100644
--- a/modules/notify/notify.c
+++ b/modules/notify/notify.c
@@ -172,7 +172,6 @@ static int ItemChange( vlc_object_t *p_this, const char *psz_var,
 
     /* Playing something ... */
     input_item_t *p_input_item = input_GetItem( p_input );
-    psz_title = input_item_GetTitleFbName( p_input_item );
 
     /* Checking for click on directories */
     if(p_input_item->i_type == ITEM_TYPE_DIRECTORY || p_input_item->i_type == ITEM_TYPE_PLAYLIST
@@ -181,6 +180,7 @@ static int ItemChange( vlc_object_t *p_this, const char *psz_var,
         return VLC_SUCCESS;
     }
 
+    psz_title = input_item_GetTitleFbName( p_input_item );
     /* We need at least a title */
     if( EMPTY_STR( psz_title ) )
     {



More information about the vlc-commits mailing list