[vlc-commits] macosx: guard unregistration of key path as well

David Fuhrmann git at videolan.org
Wed Nov 7 20:24:30 CET 2018


vlc/vlc-3.0 | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Wed Nov  7 20:20:37 2018 +0100| [23ba6163e84f17f28b92cf2b1274b657bc64173a] | committer: David Fuhrmann

macosx: guard unregistration of key path as well

Fixes a crash on exit on old systems.

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=23ba6163e84f17f28b92cf2b1274b657bc64173a
---

 modules/gui/macosx/VLCMainWindowControlsBar.m | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/modules/gui/macosx/VLCMainWindowControlsBar.m b/modules/gui/macosx/VLCMainWindowControlsBar.m
index fd482fdcdc..d87bea7a73 100644
--- a/modules/gui/macosx/VLCMainWindowControlsBar.m
+++ b/modules/gui/macosx/VLCMainWindowControlsBar.m
@@ -60,7 +60,9 @@
 
 - (void)dealloc
 {
-    [[NSApplication sharedApplication] removeObserver:self forKeyPath:@"effectiveAppearance"];
+    if (@available(macOS 10_14, *)) {
+        [[NSApplication sharedApplication] removeObserver:self forKeyPath:@"effectiveAppearance"];
+    }
 }
 
 - (void)awakeFromNib



More information about the vlc-commits mailing list