[vlc-commits] win32: remove incorrect aliasing

Rémi Denis-Courmont git at videolan.org
Tue Nov 20 16:58:54 CET 2018


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Nov 20 17:52:02 2018 +0200| [941d3f87dec481af08c87d9bdc8c5a5a29dc84a0] | committer: Rémi Denis-Courmont

win32: remove incorrect aliasing

Win32 qsort_s() is _not_ equivalent to POSIX.next/GNU qsort_r().
The order of arguments to the comparison callbacks differ.

This would cause a compile-time warning and a crash at run-time.
This change will break the build instead; this will be fixed later.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=941d3f87dec481af08c87d9bdc8c5a5a29dc84a0
---

 include/vlc_fixups.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/vlc_fixups.h b/include/vlc_fixups.h
index ad8f692271..a68dc1e820 100644
--- a/include/vlc_fixups.h
+++ b/include/vlc_fixups.h
@@ -112,10 +112,6 @@ typedef struct
 # include <dirent.h>
 #endif
 
-#ifdef _WIN32
-# define qsort_r qsort_s
-#endif
-
 #ifdef __cplusplus
 # define VLC_NOTHROW throw ()
 extern "C" {



More information about the vlc-commits mailing list