[vlc-commits] contrib: lua: Make sure to use the right AR tool for the target

Martin Storsjö git at videolan.org
Fri Nov 23 16:10:38 CET 2018


vlc/vlc-3.0 | branch: master | Martin Storsjö <martin at martin.st> | Thu Jun 14 10:22:01 2018 +0300| [14eef1d9f47c01e532daaf22a6ae8f74bc3f6672] | committer: Hugo Beauzée-Luyssen

contrib: lua: Make sure to use the right AR tool for the target

In many cases, the host AR tool just happens to work fine for e.g.
mingw cross builds, but clang targeting x86 mingw recently started
generating code that trips up GNU binutils ar, with cases like this:

ar: lcode.o: Unrecognized storage class 0 for .rdata symbol `__xmm at 8000000000000
0008000000000000000'

Just consistently use the right AR tool for the target, just like
we do for RANLIB and STRIP.

(cherry picked from commit a3d1527ecc4c775253c6822502bbaeb2a788933e)
Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=14eef1d9f47c01e532daaf22a6ae8f74bc3f6672
---

 contrib/src/lua/rules.mak | 1 +
 1 file changed, 1 insertion(+)

diff --git a/contrib/src/lua/rules.mak b/contrib/src/lua/rules.mak
index cdd4ce936b..b432edd34a 100644
--- a/contrib/src/lua/rules.mak
+++ b/contrib/src/lua/rules.mak
@@ -68,6 +68,7 @@ endif
 		-e 's%CC=%#CC=%' \
 		-e 's%= *strip%=$(STRIP)%' \
 		-e 's%= *ranlib%= $(RANLIB)%' \
+		-e 's%= *ar%= $(AR)%' \
 		Makefile
 	$(MOVE)
 



More information about the vlc-commits mailing list