[vlc-commits] demux: mkv: Remove unnecessary throw
Soomin Lee
git at videolan.org
Wed Nov 28 12:40:23 CET 2018
vlc/vlc-3.0 | branch: master | Soomin Lee <bubu at mikan.io> | Tue Nov 27 12:04:15 2018 +0100| [70073ce94983864e2d4dcba0bc5d2881329b438a] | committer: Steve Lhomme
demux: mkv: Remove unnecessary throw
This case wasn't an error in the file itself and the playback can continue
to the following files.
Additionally, throwing led to a crash on iOS 12.0.0 and iOS 12.0.1.
(ref: https://rink.hockeyapp.net/manage/apps/194470/app_versions/113/crash_reasons/242850559)
Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>
(cherry picked from commit 92b6657b0855981cc74fd652c0eac9e9d66f9987)
> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=70073ce94983864e2d4dcba0bc5d2881329b438a
---
modules/demux/mkv/matroska_segment.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/modules/demux/mkv/matroska_segment.cpp b/modules/demux/mkv/matroska_segment.cpp
index 93647113f8..29e63a2459 100644
--- a/modules/demux/mkv/matroska_segment.cpp
+++ b/modules/demux/mkv/matroska_segment.cpp
@@ -1216,7 +1216,6 @@ int matroska_segment_c::BlockGet( KaxBlock * & pp_block, KaxSimpleBlock * & pp_s
{
VLC_UNUSED( kcue );
msg_Warn( vars.p_demuxer, "find KaxCues FIXME" );
- throw VLC_EGENERIC;
}
E_CASE_DEFAULT(element)
{
More information about the vlc-commits
mailing list