[vlc-commits] contrib: postproc: Don't omit adding -DPIC on windows

Martin Storsjö git at videolan.org
Wed Nov 28 15:21:48 CET 2018


vlc/vlc-3.0 | branch: master | Martin Storsjö <martin at martin.st> | Mon Feb 26 10:37:21 2018 +0200| [cf609b81062ff06ae144b31b027e302219791e67] | committer: Hugo Beauzée-Luyssen

contrib: postproc: Don't omit adding -DPIC on windows

This fixes the earlier patch from 204d674232 to match what is done
in libav/ffmpeg's configure script even closer - even if we skip
adding -fPIC when building for windows, we still need to pass -DPIC
to pick the right form for assembler source.

(cherry picked from commit 18de5f37f1dd524705c2839b1ff3a05b92abe069)
Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=cf609b81062ff06ae144b31b027e302219791e67
---

 contrib/src/postproc/win-pic.patch | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/contrib/src/postproc/win-pic.patch b/contrib/src/postproc/win-pic.patch
index 2ce0e93164..6ed774698f 100644
--- a/contrib/src/postproc/win-pic.patch
+++ b/contrib/src/postproc/win-pic.patch
@@ -1,18 +1,16 @@
 diff -urN postproc-orig/configure postproc/configure
 --- postproc-orig/configure	2012-08-21 23:27:39.000000000 +0300
-+++ postproc/configure	2018-02-25 23:57:21.100768782 +0200
-@@ -2418,9 +2418,15 @@
- 
++++ postproc/configure	2018-02-26 10:36:48.956225615 +0200
+@@ -2419,8 +2419,14 @@
  enable_pic() {
      enable pic
--    add_cppflags -DPIC
+     add_cppflags -DPIC
 -    add_cflags   -fPIC
 -    add_asflags  -fPIC
 +    case "$target_os" in
 +    mingw*|cygwin*|win*)
 +        ;;
 +    *)
-+        add_cppflags -DPIC
 +        add_cflags   -fPIC
 +        add_asflags  -fPIC
 +        ;;



More information about the vlc-commits mailing list