[vlc-commits] macosx: PXSourceList: Use weak delegate and data source properties

David Fuhrmann git at videolan.org
Wed Oct 3 15:59:29 CEST 2018


vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Wed Oct  3 15:26:54 2018 +0200| [9aa374c061db755c0e6f8012e5bec74c3b44e5a5] | committer: David Fuhrmann

macosx: PXSourceList: Use weak delegate and data source properties

Weak should be used instead of unsafe_unretained for such cases.

See #21267

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9aa374c061db755c0e6f8012e5bec74c3b44e5a5
---

 .../PXSourceList/Internal/PXSourceListDelegateDataSourceProxy.h       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/gui/macosx/PXSourceList/Internal/PXSourceListDelegateDataSourceProxy.h b/modules/gui/macosx/PXSourceList/Internal/PXSourceListDelegateDataSourceProxy.h
index 3ea5605058..2bf8930597 100755
--- a/modules/gui/macosx/PXSourceList/Internal/PXSourceListDelegateDataSourceProxy.h
+++ b/modules/gui/macosx/PXSourceList/Internal/PXSourceListDelegateDataSourceProxy.h
@@ -13,8 +13,8 @@
 @interface PXSourceListDelegateDataSourceProxy : NSProxy <NSOutlineViewDelegate, NSOutlineViewDataSource, PXSourceListDelegate, PXSourceListDataSource>
 
 @property (weak, nonatomic) PXSourceList *sourceList;
- at property (unsafe_unretained, nonatomic) id <PXSourceListDelegate> delegate;
- at property (unsafe_unretained, nonatomic) id <PXSourceListDataSource> dataSource;
+ at property (weak, nonatomic) id <PXSourceListDelegate> delegate;
+ at property (weak, nonatomic) id <PXSourceListDataSource> dataSource;
 
 - (id)initWithSourceList:(PXSourceList *)sourceList;
 



More information about the vlc-commits mailing list