[vlc-commits] macosx: Remove VLCMainWindowSplitView

Marvin Scholz git at videolan.org
Tue Oct 9 10:58:22 CEST 2018


vlc | branch: master | Marvin Scholz <epirat07 at gmail.com> | Tue Oct  9 08:41:50 2018 +0200| [cf41442ca2ecc3ae2abd1f1284a9629f58b9059e] | committer: Marvin Scholz

macosx: Remove VLCMainWindowSplitView

The default style looks ok nowadays and hardcoding a specific color
is not good for different appearances (dark mode)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=cf41442ca2ecc3ae2abd1f1284a9629f58b9059e
---

 extras/package/macosx/VLC.xcodeproj/project.pbxproj |  4 ++--
 modules/gui/macosx/UI/MainWindow.xib                |  2 +-
 modules/gui/macosx/misc.h                           |  8 --------
 modules/gui/macosx/misc.m                           | 20 --------------------
 4 files changed, 3 insertions(+), 31 deletions(-)

diff --git a/extras/package/macosx/VLC.xcodeproj/project.pbxproj b/extras/package/macosx/VLC.xcodeproj/project.pbxproj
index 16c4b1f300..d08dca5e32 100644
--- a/extras/package/macosx/VLC.xcodeproj/project.pbxproj
+++ b/extras/package/macosx/VLC.xcodeproj/project.pbxproj
@@ -1538,7 +1538,7 @@
 					};
 				};
 			};
-			buildConfigurationList = C2F2A6EA09588F1B00018C74 /* Build configuration list for PBXProject "vlc" */;
+			buildConfigurationList = C2F2A6EA09588F1B00018C74 /* Build configuration list for PBXProject "VLC" */;
 			compatibilityVersion = "Xcode 6.3";
 			developmentRegion = English;
 			hasScannedForEncodings = 1;
@@ -1949,7 +1949,7 @@
 			defaultConfigurationIsVisible = 0;
 			defaultConfigurationName = Default;
 		};
-		C2F2A6EA09588F1B00018C74 /* Build configuration list for PBXProject "vlc" */ = {
+		C2F2A6EA09588F1B00018C74 /* Build configuration list for PBXProject "VLC" */ = {
 			isa = XCConfigurationList;
 			buildConfigurations = (
 				C2F2A6EB09588F1B00018C74 /* Development */,
diff --git a/modules/gui/macosx/UI/MainWindow.xib b/modules/gui/macosx/UI/MainWindow.xib
index ffa6cb0ee5..c0823b2ffc 100644
--- a/modules/gui/macosx/UI/MainWindow.xib
+++ b/modules/gui/macosx/UI/MainWindow.xib
@@ -28,7 +28,7 @@
                             <customView hidden="YES" focusRingType="none" translatesAutoresizingMaskIntoConstraints="NO" id="4665" customClass="VLCVoutView">
                                 <rect key="frame" x="0.0" y="0.0" width="716" height="297"/>
                             </customView>
-                            <splitView autosaveName="mainWindowSplitView" dividerStyle="thin" vertical="YES" translatesAutoresizingMaskIntoConstraints="NO" id="4680" customClass="VLCMainWindowSplitView">
+                            <splitView autosaveName="mainWindowSplitView" dividerStyle="thin" vertical="YES" translatesAutoresizingMaskIntoConstraints="NO" id="4680">
                                 <rect key="frame" x="0.0" y="0.0" width="716" height="297"/>
                                 <subviews>
                                     <customView fixedFrame="YES" id="4681">
diff --git a/modules/gui/macosx/misc.h b/modules/gui/macosx/misc.h
index 5361895e6a..e71715709d 100644
--- a/modules/gui/macosx/misc.h
+++ b/modules/gui/macosx/misc.h
@@ -49,14 +49,6 @@
 
 @end
 
-
-/*****************************************************************************
- * VLCMainWindowSplitView interface
- *****************************************************************************/
- at interface VLCMainWindowSplitView : NSSplitView
-
- at end
-
 /*****************************************************************************
  * PositionFormatter interface
  *
diff --git a/modules/gui/macosx/misc.m b/modules/gui/macosx/misc.m
index 84eec2e7d1..35b1f1ac7c 100644
--- a/modules/gui/macosx/misc.m
+++ b/modules/gui/macosx/misc.m
@@ -148,26 +148,6 @@
 
 @end
 
-
-/*****************************************************************************
- * VLCMainWindowSplitView implementation
- *****************************************************************************/
- at implementation VLCMainWindowSplitView : NSSplitView
-
-// Custom color for the dividers
-- (NSColor *)dividerColor
-{
-    return [NSColor colorWithCalibratedRed:.60 green:.60 blue:.60 alpha:1.];
-}
-
-// Custom thickness for the divider
-- (CGFloat)dividerThickness
-{
-    return 1.0;
-}
-
- at end
-
 @interface PositionFormatter()
 {
     NSCharacterSet *o_forbidden_characters;



More information about the vlc-commits mailing list