[vlc-commits] codesign.sh: Remove identifier string from sign function

[David Fuhrmann]

vlc/vlc-3.0 | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Tue Oct 23 20:43:32 2018 +0200| [d2619856cba3a2a69080ba65d7a196c376eee297] | committer: David Fuhrmann

codesign.sh: Remove identifier string from sign function

This parameter is not used anymore, instead it is determined automatically
by the codesign tool.

(cherry picked from commit d24bd15c0509f1a2d4c7e93010fe56a9d945fff2)
Signed-off-by: David Fuhrmann <dfuhrmann at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=d2619856cba3a2a69080ba65d7a196c376eee297
---

 extras/package/macosx/codesign.sh | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/extras/package/macosx/codesign.sh b/extras/package/macosx/codesign.sh
index 00957122fb..0d1a08fa35 100755
--- a/extras/package/macosx/codesign.sh
+++ b/extras/package/macosx/codesign.sh
@@ -36,7 +36,7 @@ Sign VLC.app in the current directory
 OPTIONS:
    -h            Show this help
    -i            Identity to use
-   -g            Use gatekeeper mode (additional magic)
+   -g            Developer ID certificate mode (validates with Gatekeeper)
 EOF
 
 }
@@ -79,7 +79,7 @@ if [ -z "$VLCCACHEGEN" ]; then
 info "WARN: Cannot find vlc-cache-gen, cache will be corrupt after signing"
 fi
 
-# Call with $1 = file or folder, $2 = identifier (if empty, file name is used)
+# Call with $1 = file or folder
 sign()
 {
     # info "Signing file $1 with identifier $IDENTIFIER"
@@ -98,12 +98,12 @@ info "Signing frameworks"
 sign "VLC.app/Contents/Frameworks/Growl.framework/Versions/A" "com.growl.growlframework"
 
 sign "VLC.app/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/Autoupdate.app/Contents/MacOS/fileop"
-sign "VLC.app/Contents/Frameworks/Sparkle.framework/Resources/Autoupdate.app" "org.sparkle-project.Sparkle.Autoupdate"
-sign "VLC.app/Contents/Frameworks/Sparkle.framework/Versions/A" "org.sparkle-project.Sparkle"
+sign "VLC.app/Contents/Frameworks/Sparkle.framework/Resources/Autoupdate.app"
+sign "VLC.app/Contents/Frameworks/Sparkle.framework/Versions/A"
 
 if [ -e "VLC.app/Contents/Frameworks/Breakpad.framework" ]; then
-    sign "VLC.app/Contents/Frameworks/Breakpad.framework/Resources/crash_report_sender.app" "com.Breakpad.crash_report_sender"
-    sign "VLC.app/Contents/Frameworks/Breakpad.framework/Versions/A" "com.googlecode.google-breakpad"
+    sign "VLC.app/Contents/Frameworks/Breakpad.framework/Resources/crash_report_sender.app"
+    sign "VLC.app/Contents/Frameworks/Breakpad.framework/Versions/A"
 fi
 
 info "Signing the framework headers"
@@ -164,7 +164,7 @@ do
 done
 
 info "Signing the executable"
-sign "VLC.app" "org.videolan.vlc"
+sign "VLC.app"
 
 
 info "all items signed, validating..."