[vlc-commits] macosx/mainwindow: fix potential unexpected termination

Felix Paul Kühne git at videolan.org
Tue Sep 4 17:26:57 CEST 2018


vlc | branch: master | Felix Paul Kühne <felix at feepk.net> | Tue Sep  4 17:10:27 2018 +0200| [e07a53e4c3918c1708b9916feed04dbb9f4f72f1] | committer: Felix Paul Kühne

macosx/mainwindow: fix potential unexpected termination

At present, only playlist items are allowed to be dragged

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e07a53e4c3918c1708b9916feed04dbb9f4f72f1
---

 modules/gui/macosx/VLCMainWindow.m | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/modules/gui/macosx/VLCMainWindow.m b/modules/gui/macosx/VLCMainWindow.m
index caf130bc2a..2c29cfdaaa 100644
--- a/modules/gui/macosx/VLCMainWindow.m
+++ b/modules/gui/macosx/VLCMainWindow.m
@@ -1042,6 +1042,10 @@ static const float f_min_window_height = 307.;
 
     if ([[item identifier] isEqualToString:@"playlist"])
         p_node = p_playlist->p_playing;
+    else {
+        msg_Warn(p_playlist, "dragging non-playlist items is not supported");
+        return NO;
+    }
 
     if ([[o_pasteboard types] containsObject: @"VLCPlaylistItemPboardType"]) {
         NSArray * array = [[[VLCMain sharedInstance] playlist] draggedItems];



More information about the vlc-commits mailing list