[vlc-commits] vout:display: remove the write-only has_double_click flag

Steve Lhomme git at videolan.org
Tue Apr 30 11:13:41 CEST 2019


vlc | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Wed Apr 17 15:12:55 2019 +0200| [ee75f2b1a1624ce4e1f97dae9d1de23180189b7f] | committer: Steve Lhomme

vout:display: remove the write-only has_double_click flag

This is handled in the vout window modules, not in the display modules anymore.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ee75f2b1a1624ce4e1f97dae9d1de23180189b7f
---

 include/vlc_vout_display.h              | 1 -
 modules/video_output/kva.c              | 2 --
 modules/video_output/win32/direct3d11.c | 1 -
 modules/video_output/win32/direct3d9.c  | 1 -
 modules/video_output/win32/glwin32.c    | 1 -
 modules/video_output/win32/wingdi.c     | 2 --
 6 files changed, 8 deletions(-)

diff --git a/include/vlc_vout_display.h b/include/vlc_vout_display.h
index 5b07e11f6c..bdae03881c 100644
--- a/include/vlc_vout_display.h
+++ b/include/vlc_vout_display.h
@@ -106,7 +106,6 @@ typedef struct vout_display_cfg {
  */
 typedef struct {
     bool is_slow;                           /* The picture memory has slow read/write */
-    bool has_double_click;                  /* Is double-click generated */
     bool has_pictures_invalid;              /* Can handle VOUT_DISPLAY_RESET_PICTURES */
     bool can_scale_spu;                     /* Handles subpictures with a non default zoom factor */
     const vlc_fourcc_t *subpicture_chromas; /* List of supported chromas for subpicture rendering. */
diff --git a/modules/video_output/kva.c b/modules/video_output/kva.c
index ffff7ba620..7900614019 100644
--- a/modules/video_output/kva.c
+++ b/modules/video_output/kva.c
@@ -272,8 +272,6 @@ static void PMThread( void *arg )
     /* Setup vout_display now that everything is fine */
     *fmtp       = fmt;
 
-    vd->info.has_double_click = true;
-
     vd->prepare = Prepare;
     vd->display = Display;
     vd->control = Control;
diff --git a/modules/video_output/win32/direct3d11.c b/modules/video_output/win32/direct3d11.c
index 0152f81ede..f60f9b2d95 100644
--- a/modules/video_output/win32/direct3d11.c
+++ b/modules/video_output/win32/direct3d11.c
@@ -510,7 +510,6 @@ static int Open(vout_display_t *vd, const vout_display_cfg_t *cfg,
     vout_window_SetTitle(sys->area.vdcfg.window, VOUT_TITLE " (Direct3D11 output)");
     msg_Dbg(vd, "Direct3D11 device adapter successfully initialized");
 
-    vd->info.has_double_click     = true;
     vd->info.can_scale_spu        = true;
 
     if (var_InheritBool(vd, "direct3d11-hw-blending") &&
diff --git a/modules/video_output/win32/direct3d9.c b/modules/video_output/win32/direct3d9.c
index 9d1627dc1d..ed98acdafc 100644
--- a/modules/video_output/win32/direct3d9.c
+++ b/modules/video_output/win32/direct3d9.c
@@ -1637,7 +1637,6 @@ static int Open(vout_display_t *vd, const vout_display_cfg_t *cfg,
 
     /* Setup vout_display now that everything is fine */
     vd->info.is_slow = false;
-    vd->info.has_double_click = true;
     vd->info.has_pictures_invalid = !is_d3d9_opaque(fmt.i_chroma);
 
     if (var_InheritBool(vd, "direct3d9-hw-blending") &&
diff --git a/modules/video_output/win32/glwin32.c b/modules/video_output/win32/glwin32.c
index 518fff9e14..65269e9840 100644
--- a/modules/video_output/win32/glwin32.c
+++ b/modules/video_output/win32/glwin32.c
@@ -159,7 +159,6 @@ static int Open(vout_display_t *vd, const vout_display_cfg_t *cfg,
         goto error;
 
     /* Setup vout_display now that everything is fine */
-    vd->info.has_double_click = true;
     vd->info.subpicture_chromas = subpicture_chromas;
 
     *fmtp    = fmt;
diff --git a/modules/video_output/win32/wingdi.c b/modules/video_output/win32/wingdi.c
index f44c905868..e160a804ad 100644
--- a/modules/video_output/win32/wingdi.c
+++ b/modules/video_output/win32/wingdi.c
@@ -126,8 +126,6 @@ static int Open(vout_display_t *vd, const vout_display_cfg_t *cfg,
         goto error;
 
     /* */
-    vd->info.has_double_click     = true;
-
     vd->prepare = Prepare;
     vd->display = Display;
     vd->control = Control;



More information about the vlc-commits mailing list