[vlc-commits] faad: Fix read buffer overflow

[Hugo Beauzée-Luyssen]

vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Tue Jul 30 14:07:34 2019 +0200| [6388ee66cf50051be19da364a33f2145dafbae65] | committer: Hugo Beauzée-Luyssen

faad: Fix read buffer overflow

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6388ee66cf50051be19da364a33f2145dafbae65
---

 modules/codec/faad.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/modules/codec/faad.c b/modules/codec/faad.c
index 0bb2b52dda..021aa86859 100644
--- a/modules/codec/faad.c
+++ b/modules/codec/faad.c
@@ -140,7 +140,8 @@ static int Open( vlc_object_t *p_this )
 
         if( NeAACDecInit2( p_sys->hfaad, p_dec->fmt_in.p_extra,
                            p_dec->fmt_in.i_extra,
-                           &i_rate, &i_channels ) < 0 )
+                           &i_rate, &i_channels ) < 0 ||
+                i_channels >= MPEG4_ASC_MAX_INDEXEDPOS )
         {
             msg_Err( p_dec, "Failed to initialize faad using extra data" );
             NeAACDecClose( p_sys->hfaad );