[vlc-commits] access: dvdnav: don't pass non utf8 compatible meta

Francois Cartegnie git at videolan.org
Tue Aug 27 14:50:57 CEST 2019


vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Tue Aug 27 13:05:54 2019 +0200| [7fc4fe96f9fd82e59fbab8b23e92d250d46de684] | committer: Francois Cartegnie

access: dvdnav: don't pass non utf8 compatible meta

Non iso level 1 can be forged, and dvdnav does not check

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=7fc4fe96f9fd82e59fbab8b23e92d250d46de684
---

 modules/access/dvdnav.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/access/dvdnav.c b/modules/access/dvdnav.c
index 0a915f1e6a..24bf9bbb0d 100644
--- a/modules/access/dvdnav.c
+++ b/modules/access/dvdnav.c
@@ -690,7 +690,7 @@ static int Control( demux_t *p_demux, int i_query, va_list args )
             const char *title_name = NULL;
 
             dvdnav_get_title_string(p_sys->dvdnav, &title_name);
-            if( (NULL != title_name) && ('\0' != title_name[0]) )
+            if( (NULL != title_name) && ('\0' != title_name[0]) && IsUTF8(title_name) )
             {
                 vlc_meta_t *p_meta = va_arg( args, vlc_meta_t* );
                 vlc_meta_Set( p_meta, vlc_meta_Title, title_name );



More information about the vlc-commits mailing list