[vlc-commits] mmal: code cleaning

Steve Lhomme git at videolan.org
Fri Aug 30 09:58:56 CEST 2019


vlc | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Thu Aug  8 14:31:39 2019 +0200| [1814ebcef1c1dc2ef968bbd4f6964d592ea07899] | committer: Steve Lhomme

mmal: code cleaning

Consistent with all the other variables passed to mmal_port_parameter_set

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=1814ebcef1c1dc2ef968bbd4f6964d592ea07899
---

 modules/hw/mmal/codec.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/modules/hw/mmal/codec.c b/modules/hw/mmal/codec.c
index aac0600a89..5386515361 100644
--- a/modules/hw/mmal/codec.c
+++ b/modules/hw/mmal/codec.c
@@ -101,7 +101,6 @@ static int OpenDecoder(decoder_t *dec)
 {
     int ret = VLC_SUCCESS;
     decoder_sys_t *sys;
-    MMAL_PARAMETER_UINT32_T extra_buffers;
     MMAL_STATUS_T status;
 
     if (dec->fmt_in.i_codec != VLC_CODEC_MPGV &&
@@ -179,9 +178,10 @@ static int OpenDecoder(decoder_t *dec)
     sys->output->userdata = (struct MMAL_PORT_USERDATA_T *)dec;
 
     if (sys->opaque) {
-        extra_buffers.hdr.id = MMAL_PARAMETER_EXTRA_BUFFERS;
-        extra_buffers.hdr.size = sizeof(MMAL_PARAMETER_UINT32_T);
-        extra_buffers.value = NUM_EXTRA_BUFFERS;
+        MMAL_PARAMETER_UINT32_T extra_buffers = {
+            { MMAL_PARAMETER_EXTRA_BUFFERS, sizeof(MMAL_PARAMETER_UINT32_T) },
+            NUM_EXTRA_BUFFERS
+        };
         status = mmal_port_parameter_set(sys->output, &extra_buffers.hdr);
         if (status != MMAL_SUCCESS) {
             msg_Err(dec, "Failed to set MMAL_PARAMETER_EXTRA_BUFFERS on output port (status=%"PRIx32" %s)",



More information about the vlc-commits mailing list