[vlc-commits] sd: avahi: fix use-after-free of renderer items

[Thomas Guillem]

vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Fri Feb  1 15:25:53 2019 +0100| [7e6756602054e4c32d4d4407ada7eaf9396e7023] | committer: Thomas Guillem

sd: avahi: fix use-after-free of renderer items

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=7e6756602054e4c32d4d4407ada7eaf9396e7023
---

 modules/services_discovery/avahi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/services_discovery/avahi.c b/modules/services_discovery/avahi.c
index 458d6cfd05..35c7077dd4 100644
--- a/modules/services_discovery/avahi.c
+++ b/modules/services_discovery/avahi.c
@@ -199,7 +199,6 @@ static void add_renderer( const char *psz_protocol, const char *psz_name,
     vlc_dictionary_insert( &p_sys->services_name_to_input_item,
         psz_name, p_renderer_item);
     vlc_rd_add_item( p_rd, p_renderer_item );
-    vlc_renderer_item_release( p_renderer_item );
 
 error:
     free( friendly_name );