[vlc-commits] configure: enable debug by default

Thomas Guillem git at videolan.org
Fri Feb 8 08:21:23 CET 2019


vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Thu Feb  7 13:23:13 2019 +0100| [2e66abe96f35659c726d43d4158a9ee57f14505a] | committer: Thomas Guillem

configure: enable debug by default

It seems that lot of developers forget to enable this option. This option
enables assert and other debug codes (like the very useful thread/mutex debug
code) that should be mandatory when you dev on VLC.

This is quite a big change: all VLC maintainers should now add
"--disable-debug" when they release a stable version of VLC.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2e66abe96f35659c726d43d4158a9ee57f14505a
---

 configure.ac                  | 6 +++---
 extras/package/win32/build.sh | 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index c7a9ef0d7d..1f4ac52374 100644
--- a/configure.ac
+++ b/configure.ac
@@ -989,9 +989,9 @@ dnl
 dnl  Debugging mode
 dnl
 AC_ARG_ENABLE([debug],
-  AS_HELP_STRING([--enable-debug],
-    [build with run-time assertions (default disabled)]),,
-  [enable_debug="no"])
+  AS_HELP_STRING([--disable-debug],
+    [disable run-time assertions (default enabled)]),,
+  [enable_debug="yes"])
 AH_TEMPLATE(NDEBUG,
             [Define to 1 if debug code should NOT be compiled])
 AS_IF([test "${enable_debug}" != "no"], [
diff --git a/extras/package/win32/build.sh b/extras/package/win32/build.sh
index df4bc18ee1..584145abb1 100755
--- a/extras/package/win32/build.sh
+++ b/extras/package/win32/build.sh
@@ -148,6 +148,8 @@ cd $SHORTARCH
 CONFIGFLAGS=""
 if [ "$RELEASE" != "yes" ]; then
      CONFIGFLAGS="$CONFIGFLAGS --enable-debug"
+else
+     CONFIGFLAGS="$CONFIGFLAGS --disable-debug"
 fi
 if [ "$I18N" != "yes" ]; then
      CONFIGFLAGS="$CONFIGFLAGS --disable-nls"



More information about the vlc-commits mailing list