[vlc-commits] skins2: remove useless hold/release

Rémi Denis-Courmont git at videolan.org
Thu Feb 28 20:23:26 CET 2019


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Feb 27 21:48:10 2019 +0200| [4b41ae14fa96a6fa3187bb329ff07e9725a990c7] | committer: Rémi Denis-Courmont

skins2: remove useless hold/release

Holding the VLC object of a video window achieves exactly nothing.
In this case, we just assume that the window remains valid.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4b41ae14fa96a6fa3187bb329ff07e9725a990c7
---

 modules/gui/skins2/src/vout_window.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/modules/gui/skins2/src/vout_window.cpp b/modules/gui/skins2/src/vout_window.cpp
index 95fc261bca..16a7c6904a 100644
--- a/modules/gui/skins2/src/vout_window.cpp
+++ b/modules/gui/skins2/src/vout_window.cpp
@@ -48,8 +48,6 @@ VoutWindow::VoutWindow( intf_thread_t *pIntf, vout_window_t* pWnd,
 
     if( m_pWnd )
     {
-        vlc_object_hold( m_pWnd );
-
         updateWindowConfiguration( m_pWnd );
 
         m_pTimer = pOsFactory->createOSTimer( m_cmdHideMouse );
@@ -62,7 +60,6 @@ VoutWindow::~VoutWindow()
     if( m_pWnd )
     {
         delete m_pTimer;
-        vlc_object_release( m_pWnd );
     }
 }
 



More information about the vlc-commits mailing list