[vlc-commits] contrib: libass depends on iconv

[Hugo Beauzée-Luyssen]

vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Tue Jan 15 15:03:35 2019 +0100| [b6aa8c2f0b206790c8569e450b8fa66bc77a9032] | committer: Hugo Beauzée-Luyssen

contrib: libass depends on iconv

Or rather, it can be built without it, but not depending on it can cause an
indeterministic build, with sometimes an iconv enabled libass, and
sometimes an non-iconv libass build.
On some other occasions, it can also fail:
- libiconv.a gets installed early on
- libass then determines that it can use it, regardless of iconv.h
- libass starts building
- ass.c iconv code fails to build due to missing iconv.h
- iconv.h gets installed afterward, but the build failed already

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b6aa8c2f0b206790c8569e450b8fa66bc77a9032
---

 contrib/src/ass/rules.mak | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/src/ass/rules.mak b/contrib/src/ass/rules.mak
index 66680d0c31..5ba7f11668 100644
--- a/contrib/src/ass/rules.mak
+++ b/contrib/src/ass/rules.mak
@@ -57,7 +57,7 @@ endif
 	$(UPDATE_AUTOCONFIG)
 	$(MOVE)
 
-DEPS_ass = freetype2 $(DEPS_freetype2) fribidi
+DEPS_ass = freetype2 $(DEPS_freetype2) fribidi iconv $(DEPS_iconv)
 
 ifneq ($(WITH_FONTCONFIG), 0)
 DEPS_ass += fontconfig $(DEPS_fontconfig)