[vlc-commits] xcb/xvideo: drop visibility support

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Jan 15 19:33:55 2019 +0200| [e523190a7ce15f2f87002a5474fd0de27d3c7497] | committer: Rémi Denis-Courmont

xcb/xvideo: drop visibility support

This ensures that the frame is up-to-date when the player becomes
visible - at least if a compositor is present (which is usually true).

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e523190a7ce15f2f87002a5474fd0de27d3c7497
---

 modules/video_output/xcb/xvideo.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/modules/video_output/xcb/xvideo.c b/modules/video_output/xcb/xvideo.c
index b57c7be089..62dd5c1c35 100644
--- a/modules/video_output/xcb/xvideo.c
+++ b/modules/video_output/xcb/xvideo.c
@@ -89,7 +89,6 @@ struct vout_display_sys_t
     uint32_t data_size;  /* picture byte size (for non-SHM) */
     bool     swap_uv;    /* U/V pointer must be swapped in a picture */
     bool shm;            /* whether to use MIT-SHM */
-    bool visible;        /* whether it makes sense to draw at all */
 
     xcb_xv_query_image_attributes_reply_t *att;
     picture_pool_t *pool; /* picture pool */
@@ -420,7 +419,7 @@ static int Open (vout_display_t *vd, const vout_display_cfg_t *cfg,
                 /* XCB_CW_BORDER_PIXEL */
                 screen->black_pixel,
                 /* XCB_CW_EVENT_MASK */
-                XCB_EVENT_MASK_VISIBILITY_CHANGE,
+                0,
                 /* XCB_CW_COLORMAP */
                 screen->default_colormap,
             };
@@ -488,7 +487,6 @@ static int Open (vout_display_t *vd, const vout_display_cfg_t *cfg,
     }
 
     p_sys->shm = XCB_shm_Check (obj, conn);
-    p_sys->visible = false;
 
     /* Setup vout_display_t once everything is fine */
     p_sys->swap_uv = vlc_fourcc_AreUVPlanesSwapped (fmt.i_chroma,
@@ -603,11 +601,9 @@ static void Display (vout_display_t *vd, picture_t *pic)
     xcb_shm_seg_t segment = XCB_picture_GetSegment(pic);
     xcb_void_cookie_t ck;
     video_format_t fmt;
+    bool dummy;
 
-    vlc_xcb_Manage(vd, p_sys->conn, &p_sys->visible);
-
-    if (!p_sys->visible)
-        return;
+    vlc_xcb_Manage(vd, p_sys->conn, &dummy);
 
     video_format_ApplyRotation(&fmt, &vd->source);