[vlc-commits] vout: remove invalid writes

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Jan 26 12:05:16 2019 +0200| [d6ba145f884e599f135330b307687a85711f1158] | committer: Rémi Denis-Courmont

vout: remove invalid writes

Those raced against the only read location in snapshot.c.

Regression from 2.1.0-git-1920-g17818d7bce.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d6ba145f884e599f135330b307687a85711f1158
---

 src/video_output/video_output.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
index a01a615201..407cec76c0 100644
--- a/src/video_output/video_output.c
+++ b/src/video_output/video_output.c
@@ -259,7 +259,6 @@ vout_thread_t *vout_Request(vlc_object_t *object,
 void vout_Stop(vout_thread_t *vout)
 {
     spu_Detach(vout->p->spu);
-    vout->p->input = NULL;
 
     vout_control_cmd_t cmd;
     vout_configuration_t cfg = { .fmt = NULL };
@@ -275,8 +274,6 @@ void vout_Close(vout_thread_t *vout)
     assert(vout);
 
     spu_Detach(vout->p->spu);
-    vout->p->input = NULL;
-
     vout_snapshot_End(vout->p->snapshot);
 
     vout_control_PushVoid(&vout->p->control, VOUT_CONTROL_CLEAN);