[vlc-commits] codec: substext: add some comments

Francois Cartegnie git at videolan.org
Thu Jul 4 21:55:32 CEST 2019


vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Wed Jul  3 13:40:10 2019 +0200| [bcfa771cc67f1a41ac63f38b3448c564f8baa02d] | committer: Francois Cartegnie

codec: substext: add some comments

avoid wasting time investigating "a feature"

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=bcfa771cc67f1a41ac63f38b3448c564f8baa02d
---

 modules/codec/substext.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/modules/codec/substext.h b/modules/codec/substext.h
index 50ca70a907..95de6a219f 100644
--- a/modules/codec/substext.h
+++ b/modules/codec/substext.h
@@ -140,6 +140,13 @@ static void SubpictureTextUpdate(subpicture_t *subpic,
     video_format_t fmt;
     video_format_Init(&fmt, VLC_CODEC_TEXT);
 
+    /* NOTE about fmt_dst:
+     * fmt_dst area and A/R will change to display once WxH of the
+     * display is greater than the source video in direct rendering.
+     * This will cause weird sudded region "moves" or "linebreaks" when
+     * resizing window, mostly vertically.
+     * see changes by 4a49754d943560fe79bc42f107d8ce566ea24898 */
+
     if( sys->region.flags & UPDT_REGION_USES_GRID_COORDINATES )
     {
         fmt.i_sar_num = 4;



More information about the vlc-commits mailing list