[vlc-commits] decoder: remove write-only private data

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Jul 17 23:15:54 2019 +0300| [df415944e77c9f68e990eafeb4c389b6557bae67] | committer: Rémi Denis-Courmont

decoder: remove write-only private data

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=df415944e77c9f68e990eafeb4c389b6557bae67
---

 src/input/decoder_helpers.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/input/decoder_helpers.c b/src/input/decoder_helpers.c
index 59898d1d71..015f6341b5 100644
--- a/src/input/decoder_helpers.c
+++ b/src/input/decoder_helpers.c
@@ -97,7 +97,6 @@ struct vlc_decoder_device_priv
 {
     struct vlc_decoder_device device;
     vlc_atomic_rc_t rc;
-    module_t *module;
 };
 
 static int decoder_device_Open(void *func, bool forced, va_list ap)
@@ -128,11 +127,11 @@ vlc_decoder_device_Create(vout_window_t *window)
     if (!priv)
         return NULL;
     char *name = var_InheritString(window, "dec-dev");
-    priv->module = vlc_module_load(&priv->device, "decoder device", name,
+    module_t *module = vlc_module_load(&priv->device, "decoder device", name,
                                     true, decoder_device_Open, &priv->device,
                                     window);
     free(name);
-    if (!priv->module)
+    if (module == NULL)
     {
         vlc_objres_clear(VLC_OBJECT(&priv->device));
         vlc_object_delete(&priv->device);