[vlc-commits] mux: mp4: disable faststart by default

[Francois Cartegnie]

vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Fri Jul 19 19:10:25 2019 +0200| [386d6b09c5368d55ffdadb1d0e5d3297cd013046] | committer: Francois Cartegnie

mux: mp4: disable faststart by default

Potentially moving GB of data isn't a good idea
on slow flash devices.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=386d6b09c5368d55ffdadb1d0e5d3297cd013046
---

 NEWS                  | 3 +++
 modules/mux/mp4/mp4.c | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index dcedb86f68..0f4f6d74c0 100644
--- a/NEWS
+++ b/NEWS
@@ -80,6 +80,9 @@ Stream output:
    Candidate for deprecation of decklink vout/aout modules.
  * Support for DLNA/UPNP renderers
 
+Muxers:
+ * MP4 files are no longer faststart by default
+
 Service discovery:
  * Support Renderer discovery with avahi
 
diff --git a/modules/mux/mp4/mp4.c b/modules/mux/mp4/mp4.c
index bdb0b57483..dc434d03bf 100644
--- a/modules/mux/mp4/mp4.c
+++ b/modules/mux/mp4/mp4.c
@@ -66,7 +66,7 @@ vlc_module_begin ()
     set_subcategory(SUBCAT_SOUT_MUX)
     set_shortname("MP4")
 
-    add_bool(SOUT_CFG_PREFIX "faststart", true,
+    add_bool(SOUT_CFG_PREFIX "faststart", false,
               FASTSTART_TEXT, FASTSTART_LONGTEXT,
               true)
     set_capability("sout mux", 5)