[vlc-commits] video_output: document why a callback is calling another one

Steve Lhomme git at videolan.org
Thu Jul 25 12:15:11 CEST 2019


vlc | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Wed Jul 24 14:02:37 2019 +0200| [b76b0b5779b851b8a2aaffb3a5f967881795ced4] | committer: Steve Lhomme

video_output: document why a callback is calling another one

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b76b0b5779b851b8a2aaffb3a5f967881795ced4
---

 src/video_output/video_output.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
index 490d1fa97e..073d2b023a 100644
--- a/src/video_output/video_output.c
+++ b/src/video_output/video_output.c
@@ -707,6 +707,8 @@ static picture_t *VoutVideoFilterStaticNewPicture(filter_t *filter)
 
     vlc_mutex_assert(&vout->p->filter.lock);
     if (filter_chain_IsEmpty(vout->p->filter.chain_interactive))
+        // we may be using the last filter of both chains, so we get the picture
+        // from the display module pool, just like for the last interactive filter.
         return VoutVideoFilterInteractiveNewPicture(filter);
 
     return picture_NewFromFormat(&filter->fmt_out.video);



More information about the vlc-commits mailing list