[vlc-commits] macosx: remove write-only variables

[Felix Paul Kühne]

vlc | branch: master | Felix Paul Kühne <felix at feepk.net> | Sat Jun  1 15:37:01 2019 +0200| [160c29f73d110ed9b4eae69bf8df5ebf839ec592] | committer: Felix Paul Kühne

macosx: remove write-only variables

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=160c29f73d110ed9b4eae69bf8df5ebf839ec592
---

 modules/gui/macosx/coreinteraction/VLCVideoFilterHelper.m   | 1 -
 modules/gui/macosx/panels/VLCAudioEffectsWindowController.m | 3 +--
 modules/gui/macosx/panels/VLCVideoEffectsWindowController.m | 3 ---
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/modules/gui/macosx/coreinteraction/VLCVideoFilterHelper.m b/modules/gui/macosx/coreinteraction/VLCVideoFilterHelper.m
index fb6627fb9f..e0ef0cd438 100644
--- a/modules/gui/macosx/coreinteraction/VLCVideoFilterHelper.m
+++ b/modules/gui/macosx/coreinteraction/VLCVideoFilterHelper.m
@@ -121,7 +121,6 @@
         return;
 
     int i_type = 0;
-    bool b_is_command = false;
     char const *psz_filter_type = [self getFilterType: psz_filter];
     if (!psz_filter_type) {
         msg_Err(p_intf, "Unable to find filter module \"%s\".", psz_filter);
diff --git a/modules/gui/macosx/panels/VLCAudioEffectsWindowController.m b/modules/gui/macosx/panels/VLCAudioEffectsWindowController.m
index 20b3c74c21..b91069c471 100644
--- a/modules/gui/macosx/panels/VLCAudioEffectsWindowController.m
+++ b/modules/gui/macosx/panels/VLCAudioEffectsWindowController.m
@@ -103,7 +103,7 @@
     self = [super initWithWindowNibName:@"AudioEffects"];
     if (self) {
         dispatch_async(dispatch_get_main_queue(), ^{
-            _playerController = [[[VLCMain sharedInstance] playlistController] playerController];
+            self->_playerController = [[[VLCMain sharedInstance] playlistController] playerController];
 
             self.popupPanel = [[VLCPopupPanelController alloc] init];
             self.textfieldPanel = [[VLCTextfieldPanelController alloc] init];
@@ -138,7 +138,6 @@
 /// Loads values from profile into variables
 - (void)loadProfile
 {
-    intf_thread_t *p_intf = getIntf();
     NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
     NSInteger profileIndex = [self currentProfileIndex];
     audio_output_t *p_aout = [_playerController mainAudioOutput];
diff --git a/modules/gui/macosx/panels/VLCVideoEffectsWindowController.m b/modules/gui/macosx/panels/VLCVideoEffectsWindowController.m
index 254b04f6cc..39a0c1efac 100644
--- a/modules/gui/macosx/panels/VLCVideoEffectsWindowController.m
+++ b/modules/gui/macosx/panels/VLCVideoEffectsWindowController.m
@@ -25,7 +25,6 @@
 #import "coreinteraction/VLCVideoFilterHelper.h"
 #import "extensions/VLCHexNumberFormatter.h"
 #import "extensions/NSString+Helpers.h"
-#import "main/CompatibilityFixes.h"
 #import "main/VLCMain.h"
 #import "panels/dialogs/VLCPopupPanelController.h"
 #import "panels/dialogs/VLCTextfieldPanelController.h"
@@ -471,7 +470,6 @@
 /// Sets widget values based on variables
 - (void)resetValues
 {
-    intf_thread_t *p_intf = getIntf();
     VLCPlayerController *playerController = [[[VLCMain sharedInstance] playlistController] playerController];
     vout_thread_t *vout = [playerController mainVideoOutputThread];
     if (!vout)
@@ -647,7 +645,6 @@
 
 - (NSString *)generateProfileString
 {
-    intf_thread_t *p_intf = getIntf();
     VLCPlayerController *playerController = [[[VLCMain sharedInstance] playlistController] playerController];
     vout_thread_t *vout = [playerController mainVideoOutputThread];
     if (!vout)