[vlc-commits] preparser: fix dereference of uninitialized pointer

[Thomas Guillem]

vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Wed Jun  5 09:21:42 2019 +0200| [3c70e9587eed0a0f1f95d1e3bacfa3c2621ff9b4] | committer: Thomas Guillem

preparser: fix dereference of uninitialized pointer

task->ref could be accessed from the input item preparser before being set.

Fixes #22377

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3c70e9587eed0a0f1f95d1e3bacfa3c2621ff9b4
---

 src/preparser/preparser.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/preparser/preparser.c b/src/preparser/preparser.c
index 5f39432cd3..f59519aef1 100644
--- a/src/preparser/preparser.c
+++ b/src/preparser/preparser.c
@@ -128,14 +128,13 @@ static int PreparserOpenInput( void* preparser_, void* req_, void** out )
     atomic_init( &task->done, false );
 
     task->preparser = preparser_;
+    task->req = req;
+    task->preparse_status = -1;
     task->parser = input_item_Parse( req->item, preparser->owner, &cbs,
                                      task );
     if( !task->parser )
         goto error;
 
-    task->req = req;
-    task->preparse_status = -1;
-
     *out = task;
 
     return VLC_SUCCESS;