[vlc-commits] i420_rgb: remove redundant lines

Lyndon Brown git at videolan.org
Wed Mar 6 17:13:28 CET 2019


vlc | branch: master | Lyndon Brown <jnqnfe at gmail.com> | Sun Jan 20 04:42:25 2019 +0000| [bac92fcbc5f05a896e42bf8927c5bf465061c6f7] | committer: Jean-Baptiste Kempf

i420_rgb: remove redundant lines

p_buffer was being reset both at start and end of loops in unaligned SSE2
branch

also, added empty line after initial value set prior to alignment check
for clarity

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=bac92fcbc5f05a896e42bf8927c5bf465061c6f7
---

 modules/video_chroma/i420_rgb16_x86.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/modules/video_chroma/i420_rgb16_x86.c b/modules/video_chroma/i420_rgb16_x86.c
index 205daab0de..49a49e36db 100644
--- a/modules/video_chroma/i420_rgb16_x86.c
+++ b/modules/video_chroma/i420_rgb16_x86.c
@@ -171,6 +171,7 @@ void I420_R5G5B5( filter_t *p_filter, picture_t *p_src, picture_t *p_dest )
     */
 
     p_buffer = b_hscale ? p_buffer_start : p_pic;
+
     if( 0 == (15 & (p_src->p[Y_PLANE].i_pitch|
                     p_dest->p->i_pitch|
                     ((intptr_t)p_y)|
@@ -231,7 +232,6 @@ void I420_R5G5B5( filter_t *p_filter, picture_t *p_src, picture_t *p_dest )
         for( i_y = 0; i_y < (p_filter->fmt_in.video.i_y_offset + p_filter->fmt_in.video.i_visible_height); i_y++ )
         {
             p_pic_start = p_pic;
-            p_buffer = b_hscale ? p_buffer_start : p_pic;
 
             for ( i_x = (p_filter->fmt_in.video.i_x_offset + p_filter->fmt_in.video.i_visible_width)/16; i_x--; )
             {
@@ -412,6 +412,7 @@ void I420_R5G6B5( filter_t *p_filter, picture_t *p_src, picture_t *p_dest )
     */
 
     p_buffer = b_hscale ? p_buffer_start : p_pic;
+
     if( 0 == (15 & (p_src->p[Y_PLANE].i_pitch|
                     p_dest->p->i_pitch|
                     ((intptr_t)p_y)|
@@ -472,7 +473,6 @@ void I420_R5G6B5( filter_t *p_filter, picture_t *p_src, picture_t *p_dest )
         for( i_y = 0; i_y < (p_filter->fmt_in.video.i_y_offset + p_filter->fmt_in.video.i_visible_height); i_y++ )
         {
             p_pic_start = p_pic;
-            p_buffer = b_hscale ? p_buffer_start : p_pic;
 
             for ( i_x = (p_filter->fmt_in.video.i_x_offset + p_filter->fmt_in.video.i_visible_width)/16; i_x--; )
             {
@@ -653,6 +653,7 @@ void I420_A8R8G8B8( filter_t *p_filter, picture_t *p_src,
     */
 
     p_buffer = b_hscale ? p_buffer_start : p_pic;
+
     if( 0 == (15 & (p_src->p[Y_PLANE].i_pitch|
                     p_dest->p->i_pitch|
                     ((intptr_t)p_y)|
@@ -713,7 +714,6 @@ void I420_A8R8G8B8( filter_t *p_filter, picture_t *p_src,
         for( i_y = 0; i_y < (p_filter->fmt_in.video.i_y_offset + p_filter->fmt_in.video.i_visible_height); i_y++ )
         {
             p_pic_start = p_pic;
-            p_buffer = b_hscale ? p_buffer_start : p_pic;
 
             for ( i_x = (p_filter->fmt_in.video.i_x_offset + p_filter->fmt_in.video.i_visible_width) / 16; i_x--; )
             {
@@ -893,6 +893,7 @@ void I420_R8G8B8A8( filter_t *p_filter, picture_t *p_src, picture_t *p_dest )
     */
 
     p_buffer = b_hscale ? p_buffer_start : p_pic;
+
     if( 0 == (15 & (p_src->p[Y_PLANE].i_pitch|
                     p_dest->p->i_pitch|
                     ((intptr_t)p_y)|
@@ -953,7 +954,6 @@ void I420_R8G8B8A8( filter_t *p_filter, picture_t *p_src, picture_t *p_dest )
         for( i_y = 0; i_y < (p_filter->fmt_in.video.i_y_offset + p_filter->fmt_in.video.i_visible_height); i_y++ )
         {
             p_pic_start = p_pic;
-            p_buffer = b_hscale ? p_buffer_start : p_pic;
 
             for ( i_x = (p_filter->fmt_in.video.i_x_offset + p_filter->fmt_in.video.i_visible_width) / 16; i_x--; )
             {
@@ -1133,6 +1133,7 @@ void I420_B8G8R8A8( filter_t *p_filter, picture_t *p_src, picture_t *p_dest )
     */
 
     p_buffer = b_hscale ? p_buffer_start : p_pic;
+
     if( 0 == (15 & (p_src->p[Y_PLANE].i_pitch|
                     p_dest->p->i_pitch|
                     ((intptr_t)p_y)|
@@ -1193,7 +1194,6 @@ void I420_B8G8R8A8( filter_t *p_filter, picture_t *p_src, picture_t *p_dest )
         for( i_y = 0; i_y < (p_filter->fmt_in.video.i_y_offset + p_filter->fmt_in.video.i_visible_height); i_y++ )
         {
             p_pic_start = p_pic;
-            p_buffer = b_hscale ? p_buffer_start : p_pic;
 
             for ( i_x = (p_filter->fmt_in.video.i_x_offset + p_filter->fmt_in.video.i_visible_width) / 16; i_x--; )
             {
@@ -1370,6 +1370,7 @@ void I420_A8B8G8R8( filter_t *p_filter, picture_t *p_src, picture_t *p_dest )
     */
 
     p_buffer = b_hscale ? p_buffer_start : p_pic;
+
     if( 0 == (15 & (p_src->p[Y_PLANE].i_pitch|
                     p_dest->p->i_pitch|
                     ((intptr_t)p_y)|
@@ -1430,7 +1431,6 @@ void I420_A8B8G8R8( filter_t *p_filter, picture_t *p_src, picture_t *p_dest )
         for( i_y = 0; i_y < (p_filter->fmt_in.video.i_y_offset + p_filter->fmt_in.video.i_visible_height); i_y++ )
         {
             p_pic_start = p_pic;
-            p_buffer = b_hscale ? p_buffer_start : p_pic;
 
             for ( i_x = (p_filter->fmt_in.video.i_x_offset + p_filter->fmt_in.video.i_visible_width) / 16; i_x--; )
             {



More information about the vlc-commits mailing list