[vlc-commits] macosx: remove useless hold/release

Rémi Denis-Courmont git at videolan.org
Sat Mar 16 11:07:55 CET 2019


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Fri Mar 15 04:22:34 2019 +0200| [9451397635c9e81d018b6d27c41336b47c1ca58e] | committer: Rémi Denis-Courmont

macosx: remove useless hold/release

The menu item already has a reference.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9451397635c9e81d018b6d27c41336b47c1ca58e
---

 modules/gui/macosx/menus/VLCMainMenu.m | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/modules/gui/macosx/menus/VLCMainMenu.m b/modules/gui/macosx/menus/VLCMainMenu.m
index f4f2491ca4..a79c99214a 100644
--- a/modules/gui/macosx/menus/VLCMainMenu.m
+++ b/modules/gui/macosx/menus/VLCMainMenu.m
@@ -1580,7 +1580,6 @@
 
         p_object = [menuContent vlcObject];
         var_Set(p_object, [menuContent name], [menuContent value]);
-        vlc_object_release(p_object);
         return true;
     }
 }
@@ -1757,7 +1756,7 @@
 
 - (vlc_object_t *)vlcObject
 {
-    return vlc_object_hold(vlc_object);
+    return vlc_object;
 }
 
 - (int)type



More information about the vlc-commits mailing list