[vlc-commits] qt: remove useless hold/release

Rémi Denis-Courmont git at videolan.org
Sat Mar 16 11:07:52 CET 2019


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Mar 16 07:06:46 2019 +0200| [b6f12c138b66fb511ef66b4c756d9988e629cf1f] | committer: Rémi Denis-Courmont

qt: remove useless hold/release

The playlist cannot go away while the interface is running.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b6f12c138b66fb511ef66b4c756d9988e629cf1f
---

 modules/gui/qt/adapters/variables.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/modules/gui/qt/adapters/variables.cpp b/modules/gui/qt/adapters/variables.cpp
index 6ef90ce17b..22597b6466 100644
--- a/modules/gui/qt/adapters/variables.cpp
+++ b/modules/gui/qt/adapters/variables.cpp
@@ -30,8 +30,6 @@ QVLCVariable::QVLCVariable (vlc_object_t *obj, const char *varname, int type,
                             bool inherit)
     : object (obj), name (qfu(varname))
 {
-    vlc_object_hold (object);
-
     if (inherit)
         type |= VLC_VAR_DOINHERIT;
     var_Create (object, qtu(name), type);
@@ -42,7 +40,6 @@ QVLCVariable::~QVLCVariable (void)
 {
     var_DelCallback (object, qtu(name), callback, this);
     var_Destroy (object, qtu(name));
-    vlc_object_release (object);
 }
 
 int QVLCVariable::callback(vlc_object_t *, const char *,



More information about the vlc-commits mailing list