[vlc-commits] wave: fix green output

Lyndon Brown git at videolan.org
Wed Mar 20 15:34:40 CET 2019


vlc | branch: master | Lyndon Brown <jnqnfe at gmail.com> | Sun Mar 17 06:40:22 2019 +0000| [ead3cb537fd069c0dadea5f0af5a8d12de71c6ae] | committer: Thomas Guillem

wave: fix green output

right-hand indentations were partially or fully green, depending upon
the resolution of the video, for videos where pitch != visible_pitch

Signed-off-by: Thomas Guillem <thomas at gllm.fr>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ead3cb537fd069c0dadea5f0af5a8d12de71c6ae
---

 modules/video_filter/wave.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/modules/video_filter/wave.c b/modules/video_filter/wave.c
index 0a272e998c..9631a90db4 100644
--- a/modules/video_filter/wave.c
+++ b/modules/video_filter/wave.c
@@ -176,9 +176,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
                 {
                     memcpy( p_out, p_in - i_offset,
                                 i_visible_pitch + i_offset );
-                    p_in += p_pic->p[i_index].i_pitch;
-                    p_out += p_outpic->p[i_index].i_pitch;
-                    p_black_out = &p_out[i_offset];
+                    p_black_out = &p_out[i_visible_pitch + i_offset];
                     i_offset = -i_offset;
                 }
                 else
@@ -186,8 +184,6 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
                     memcpy( p_out + i_offset, p_in,
                                 i_visible_pitch - i_offset );
                     p_black_out = p_out;
-                    p_in += p_pic->p[i_index].i_pitch;
-                    p_out += p_outpic->p[i_index].i_pitch;
                 }
                 if (black_pixel > 0xFF)
                 {
@@ -201,10 +197,9 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
             else
             {
                 memcpy( p_out, p_in, i_visible_pitch );
-                p_in += p_pic->p[i_index].i_pitch;
-                p_out += p_outpic->p[i_index].i_pitch;
             }
-
+            p_in += p_pic->p[i_index].i_pitch;
+            p_out += p_outpic->p[i_index].i_pitch;
         }
     }
 



More information about the vlc-commits mailing list