[vlc-commits] Revert "Made http-continuous option safe."

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Mar 27 18:20:16 2019 +0200| [29da829f6810c0746a14a2030cc712808c03ab39] | committer: Rémi Denis-Courmont

Revert "Made http-continuous option safe."

As seen 3 years ago with libavformat concat, concatenating streams
leads to interesting security issues such as data exfiltration.
http-continuous is essentially concatenating multiple HTTP resources.

This makes the concatenation-controlling option unsafe as is already
done within the VLC concat module.

This reverts commit b6c17b225587f750737204335f74ec00142bc758.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=29da829f6810c0746a14a2030cc712808c03ab39
---

 modules/access/http/access.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/access/http/access.c b/modules/access/http/access.c
index bda906b47b..97f0e7f1f1 100644
--- a/modules/access/http/access.c
+++ b/modules/access/http/access.c
@@ -298,7 +298,6 @@ vlc_module_begin()
 
     add_bool("http-continuous", false, N_("Continuous stream"),
              N_("Keep reading a resource that keeps being updated."), true)
-        change_safe()
         change_volatile()
     add_bool("http-forward-cookies", true, N_("Cookies forwarding"),
              N_("Forward cookies across HTTP redirections."), true)