[vlc-commits] macos info.plist strings: Factorize translatable strings

[David Fuhrmann]

vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Sun May 19 11:53:24 2019 +0200| [17ff486e0c3b42cb15840fbaebe648c85993c969] | committer: David Fuhrmann

macos info.plist strings: Factorize translatable strings

Some strings do not need to be translated here.
CFBundleGetInfoString is replaced by NSHumanReadableCopyright,
therefore not needed anymore.

The usage strings always need to be in Info.plist as a fallback,
otherwise the app might crash if a translated version is not
found.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=17ff486e0c3b42cb15840fbaebe648c85993c969
---

 modules/gui/macosx/Resources/InfoPlist.strings.in |  4 ----
 share/Info.plist.in                               | 14 ++++++++++----
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/modules/gui/macosx/Resources/InfoPlist.strings.in b/modules/gui/macosx/Resources/InfoPlist.strings.in
index 67121a26aa..6c2ca0db83 100644
--- a/modules/gui/macosx/Resources/InfoPlist.strings.in
+++ b/modules/gui/macosx/Resources/InfoPlist.strings.in
@@ -1,9 +1,5 @@
 /* Localized versions of Info.plist keys */
 
-"CFBundleName" = "VLC";
-"CFBundleDisplayName" = "VLC";
-"CFBundleShortVersionString" = "@VERSION@";
-"CFBundleGetInfoString" = "@COPYRIGHT_MESSAGE@";
 "NSHumanReadableCopyright" = "Copyright (c) @COPYRIGHT_YEARS@ VLC authors and VideoLAN";
 
 "NSCameraUsageDescription" = "VLC uses the camera to record some video.";
diff --git a/share/Info.plist.in b/share/Info.plist.in
index 60e363fe2a..5bd44efd8b 100644
--- a/share/Info.plist.in
+++ b/share/Info.plist.in
@@ -1398,8 +1398,6 @@
 	</array>
 	<key>CFBundleExecutable</key>
 	<string>VLC</string>
-	<key>CFBundleGetInfoString</key>
-	<string>@COPYRIGHT_MESSAGE@</string>
 	<key>CFBundleIconFile</key>
 	<string>VLC.icns</string>
 	<key>CFBundleIdentifier</key>
@@ -1410,10 +1408,10 @@
 	<string>VLC media player</string>
 	<key>CFBundleDisplayName</key>
 	<string>VLC</string>
-	<key>CFBundlePackageType</key>
-	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
 	<string>@VERSION@</string>
+	<key>CFBundlePackageType</key>
+	<string>APPL</string>
 	<key>CFBundleSignature</key>
 	<string>VLC#</string>
 	<key>BreakpadProduct</key>
@@ -1424,6 +1422,14 @@
 	<string>1</string>
 	<key>BreakpadURL</key>
 	<string>@BREAKPAD_URL@/reports</string>
+	<key>NSHumanReadableCopyright</key>
+	<string>Copyright (c) @COPYRIGHT_YEARS@ VLC authors and VideoLAN</string>
+	<key>NSCameraUsageDescription</key>
+	<string>VLC uses the camera to record some video.</string>
+	<key>NSMicrophoneUsageDescription</key>
+	<string>VLC uses the microphone to record some audio.</string>
+	<key>NSAppleEventsUsageDescription</key>
+	<string>VLC uses apple events to control external media players.</string>
 	<key>CFBundleURLTypes</key>
 	<array>
 		<dict>