[vlc-commits] oldrc: remove dead code

Rémi Denis-Courmont git at videolan.org
Sun May 19 19:20:12 CEST 2019


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun May 19 18:59:43 2019 +0300| [16f4ac470104f7a4ad08f02f201b5ae06df4d167] | committer: Rémi Denis-Courmont

oldrc: remove dead code

There are no "command" variables on the LibVLC instance object left.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=16f4ac470104f7a4ad08f02f201b5ae06df4d167
---

 modules/control/oldrc.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/modules/control/oldrc.c b/modules/control/oldrc.c
index a348ef32d5..a1106b9cd7 100644
--- a/modules/control/oldrc.c
+++ b/modules/control/oldrc.c
@@ -675,23 +675,6 @@ static void *Run( void *data )
             msg_rc( "%s: returned %i (%s)",
                     psz_cmd, i_ret, vlc_error_string( i_ret ) );
         }
-        /* Or maybe it's a global command */
-        else if( var_Type( vlc, psz_cmd ) & VLC_VAR_ISCOMMAND )
-        {
-            int i_ret = VLC_SUCCESS;
-
-            /* FIXME: it's a global command, but we should pass the
-             * local object as an argument, not vlc_object_instance(p_intf). */
-            if ((var_Type( vlc, psz_cmd) & VLC_VAR_CLASS) == VLC_VAR_VOID)
-                var_TriggerCallback( p_intf, psz_cmd );
-            else
-                i_ret = var_SetString( vlc, psz_cmd, psz_arg );
-            if( i_ret != 0 )
-            {
-                msg_rc( "%s: returned %i (%s)",
-                         psz_cmd, i_ret, vlc_error_string( i_ret ) );
-            }
-        }
         else if( !strcmp( psz_cmd, "logout" ) )
         {
             /* Close connection */



More information about the vlc-commits mailing list