[vlc-commits] audioscrobbler: fix error code

Rémi Denis-Courmont git at videolan.org
Sun May 19 19:20:22 CEST 2019


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun May 19 20:04:41 2019 +0300| [f11c730d8532e54ac972720d8b8a9308da01b3d5] | committer: Rémi Denis-Courmont

audioscrobbler: fix error code

Empty string is invalid value, not missing object variable...

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f11c730d8532e54ac972720d8b8a9308da01b3d5
---

 modules/misc/audioscrobbler.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/misc/audioscrobbler.c b/modules/misc/audioscrobbler.c
index 19fd4729b2..f6d38879f6 100644
--- a/modules/misc/audioscrobbler.c
+++ b/modules/misc/audioscrobbler.c
@@ -494,7 +494,7 @@ static int Handshake(intf_thread_t *p_this)
     {
         free(psz_username);
         free(psz_password);
-        return VLC_ENOVAR;
+        return VLC_EBADVAR;
     }
 
     time(&timestamp);
@@ -725,7 +725,7 @@ static void *Run(void *data)
                 case VLC_ENOMEM:
                     goto out;
 
-                case VLC_ENOVAR:
+                case VLC_EBADVAR:
                     /* username not set */
                     vlc_dialog_display_error(p_intf,
                         _("Last.fm username not set"),



More information about the vlc-commits mailing list