[vlc-commits] dmo: Fix use after free

[Hugo Beauzée-Luyssen]

vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Tue May 21 13:59:56 2019 +0200| [c6b07d7cec3c2684f4bbc702cd1be6f18813f8f2] | committer: Hugo Beauzée-Luyssen

dmo: Fix use after free

https://hackerone.com/reports/513704

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c6b07d7cec3c2684f4bbc702cd1be6f18813f8f2
---

 modules/codec/dmo/dmo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/codec/dmo/dmo.c b/modules/codec/dmo/dmo.c
index c63090cff2..f129ab9ef1 100644
--- a/modules/codec/dmo/dmo.c
+++ b/modules/codec/dmo/dmo.c
@@ -845,6 +845,7 @@ static int DecBlock( decoder_t *p_dec, block_t **pp_block )
                        (IMediaBuffer *)p_in, DMO_INPUT_DATA_BUFFERF_SYNCPOINT,
                        0, 0 );
 
+        *pp_block = NULL;
         p_in->vt->Release( (IUnknown *)p_in );
 
         if( i_result == S_FALSE )
@@ -870,7 +871,6 @@ static int DecBlock( decoder_t *p_dec, block_t **pp_block )
 #ifdef DMO_DEBUG
             msg_Dbg( p_dec, "ProcessInput(): successful" );
 #endif
-            *pp_block = NULL;
         }
     }