[vlc-commits] video_chroma:copy: fix the number of lines for the second NV12 planes

Steve Lhomme git at videolan.org
Thu May 23 17:40:11 CEST 2019


vlc/vlc-3.0 | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Tue Jan 29 15:59:23 2019 +0100| [4de04606170d014c8b6ccca9fa5e896cca7af3af] | committer: Hugo Beauzée-Luyssen

video_chroma:copy: fix the number of lines for the second NV12 planes

The pitch is similar to the full picture, but there's half the lines.

Compared to I420 where the second/third planes have half width and half height.

https://hackerone.com/reports/485437

Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>
(cherry picked from commit eeb662bca2ab1dfd8e027606be84f7906b175a76)
Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=4de04606170d014c8b6ccca9fa5e896cca7af3af
---

 modules/video_chroma/copy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/video_chroma/copy.c b/modules/video_chroma/copy.c
index 2b3a49a034..08f41f164b 100644
--- a/modules/video_chroma/copy.c
+++ b/modules/video_chroma/copy.c
@@ -969,7 +969,7 @@ int picture_UpdatePlanes(picture_t *picture, uint8_t *data, unsigned pitch)
 
             p->p_pixels = o->p_pixels + o->i_lines * o->i_pitch;
             p->i_pitch  = pitch;
-            p->i_lines  = picture->format.i_height;
+            p->i_lines  = picture->format.i_height / 2;
             assert(p->i_visible_pitch <= p->i_pitch);
             assert(p->i_visible_lines <= p->i_lines);
         }



More information about the vlc-commits mailing list