[vlc-commits] rc: fix potential use-after-free

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue May 28 19:45:25 2019 +0300| [60eb593c1870dce088ed2a96e347a3f2e2ce9b51] | committer: Rémi Denis-Courmont

rc: fix potential use-after-free

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=60eb593c1870dce088ed2a96e347a3f2e2ce9b51
---

 modules/control/oldrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/control/oldrc.c b/modules/control/oldrc.c
index 365eaeab95..0bc3aa526d 100644
--- a/modules/control/oldrc.c
+++ b/modules/control/oldrc.c
@@ -634,8 +634,8 @@ static void PlayerGetTitle(intf_thread_t *intf)
 
     vlc_player_Lock(player);
     title = vlc_player_GetSelectedTitle(player);
-    vlc_player_Unlock(player);
     msg_print(intf, "%s", (title != NULL) ? title->name : "");
+    vlc_player_Unlock(player);
 }
 
 static void PlayerVoutSnapshot(intf_thread_t *intf)