[vlc-commits] decoder: remove redundant chroma fix in FixDisplayFormat

Steve Lhomme git at videolan.org
Mon Nov 4 10:41:54 CET 2019


vlc | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Mon Oct 28 11:22:13 2019 +0100| [815b4588e797121e43fc72521b732ca3afe434e6] | committer: Steve Lhomme

decoder: remove redundant chroma fix in FixDisplayFormat

It's redundant when FixDisplayFormat is called from the update_format callback.

When called from CreateVoutIfNeeded in the get_device callback, the chroma of
the source format doesn't change the decoder device creation. The value is
likely not even set during that call anyway.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=815b4588e797121e43fc72521b732ca3afe434e6
---

 src/input/decoder.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/input/decoder.c b/src/input/decoder.c
index c9802b9a00..8f04bd6154 100644
--- a/src/input/decoder.c
+++ b/src/input/decoder.c
@@ -405,7 +405,6 @@ static int ModuleThread_UpdateAudioFormat( decoder_t *p_dec )
 static void FixDisplayFormat(decoder_t *p_dec, video_format_t *fmt)
 {
     *fmt = p_dec->fmt_out.video;
-    fmt->i_chroma = p_dec->fmt_out.i_codec;
 
     if( vlc_fourcc_IsYUV( fmt->i_chroma ) )
     {



More information about the vlc-commits mailing list