[vlc-commits] qml: fix SortControl combo box position

[Pierre Lamot]

vlc | branch: master | Pierre Lamot <pierre at videolabs.io> | Fri Nov 15 15:46:28 2019 +0100| [aeb018ac74f6ea472d18c52a6ee7bd3ce94c8e3c] | committer: Jean-Baptiste Kempf

qml: fix SortControl combo box position

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=aeb018ac74f6ea472d18c52a6ee7bd3ce94c8e3c
---

 modules/gui/qt/qml/BannerSources.qml     | 2 +-
 modules/gui/qt/qml/utils/SortControl.qml | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/modules/gui/qt/qml/BannerSources.qml b/modules/gui/qt/qml/BannerSources.qml
index f835d0689a..7e034b96cb 100644
--- a/modules/gui/qt/qml/BannerSources.qml
+++ b/modules/gui/qt/qml/BannerSources.qml
@@ -212,7 +212,7 @@ Utils.NavigableFocusScope {
                             textRole: "text"
                             listWidth: VLCStyle.widthSortBox
 
-                            popupAlignment: Qt.AlignLeft
+                            popupAlignment: Qt.AlignLeft | Qt.AlignBottom
 
                             visible: !!root.contentModel
                             enabled: visible
diff --git a/modules/gui/qt/qml/utils/SortControl.qml b/modules/gui/qt/qml/utils/SortControl.qml
index 72e65ace31..091b9ed66f 100644
--- a/modules/gui/qt/qml/utils/SortControl.qml
+++ b/modules/gui/qt/qml/utils/SortControl.qml
@@ -59,12 +59,13 @@ Utils.NavigableFocusScope {
             else
                 popup.open()
         }
+
     }
 
     Popup {
         id: popup
 
-        y: (popupAlignment & Qt.AlignBottom) ? (root.height - 1) : 1
+        y: (popupAlignment & Qt.AlignBottom) ? (root.height + 1) : - (implicitHeight + 1)
         x: (popupAlignment & Qt.AlignRight) ? (button.width - width) :  0
         width: root.listWidth
         implicitHeight: contentItem.implicitHeight + padding * 2