[vlc-commits] qml: fix items wrongly highlited when scrolling the ExpandGridView

Pierre Lamot git at videolan.org
Mon Oct 14 11:59:47 CEST 2019


vlc | branch: master | Pierre Lamot <pierre at videolabs.io> | Mon Sep 30 17:09:41 2019 +0200| [a59ee13e4645532ef26bac9986c874e034c60341] | committer: Jean-Baptiste Kempf

qml: fix items wrongly highlited when scrolling the ExpandGridView

  recycled items where keeping the focus property, so they appeared like they
  where having the focus/being selected

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a59ee13e4645532ef26bac9986c874e034c60341
---

 modules/gui/qt/qml/utils/ExpandGridView.qml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/modules/gui/qt/qml/utils/ExpandGridView.qml b/modules/gui/qt/qml/utils/ExpandGridView.qml
index f1fa8f4987..1d55377ebf 100644
--- a/modules/gui/qt/qml/utils/ExpandGridView.qml
+++ b/modules/gui/qt/qml/utils/ExpandGridView.qml
@@ -239,6 +239,7 @@ NavigableFocusScope {
                 item.model = model.items.get(i).model
                 item.index = i
                 item.selected = model.items.get(i).inSelected
+                item.focus = false
                 item.x = pos[0]
                 item.y = pos[1]
                 item.visible = true
@@ -252,6 +253,7 @@ NavigableFocusScope {
                 pos = getItemPos(i)
                 item = getChild(i, _unusedItemList)
                 item.model = model.items.get(i).model
+                item.focus = false
                 item.index = i
                 item.selected = model.items.get(i).inSelected
                 item.x = pos[0]



More information about the vlc-commits mailing list