[vlc-commits] qt: firstrun: remove obsolete warning
Alexandre Janniaux
git at videolan.org
Thu Oct 31 00:54:47 CET 2019
vlc | branch: master | Alexandre Janniaux <ajanni at videolabs.io> | Sat Oct 26 16:26:32 2019 +0200| [cd3d68dda5f40f1eed6239796fd66204ece7b0fe] | committer: Jean-Baptiste Kempf
qt: firstrun: remove obsolete warning
The configuration file is locked before serialization and the
config_SaveConfigFile can thus be called at multiple places at the same
time.
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=cd3d68dda5f40f1eed6239796fd66204ece7b0fe
---
modules/gui/qt/dialogs/firstrun.cpp | 3 ---
1 file changed, 3 deletions(-)
diff --git a/modules/gui/qt/dialogs/firstrun.cpp b/modules/gui/qt/dialogs/firstrun.cpp
index 4297d15113..a0b9530838 100644
--- a/modules/gui/qt/dialogs/firstrun.cpp
+++ b/modules/gui/qt/dialogs/firstrun.cpp
@@ -44,9 +44,6 @@ void FirstRun::save()
#endif
config_PutInt( "qt-privacy-ask", 0 );
- /* FIXME Should not save here. This will not work as expected if another
- * plugin overwrote items of its own. */
-#warning FIXME
/* We have to save here because the user may not launch Prefs */
config_SaveConfigFile( p_intf );
close();
More information about the vlc-commits
mailing list