[vlc-commits] qml: ExpandGridView should have a vertical scrollbar

[Pierre Lamot]

vlc | branch: master | Pierre Lamot <pierre at videolabs.io> | Tue Aug 27 14:46:04 2019 +0200| [68d1b23be84009e11f4a0dd97a9818f342b9c4d1] | committer: Jean-Baptiste Kempf

qml: ExpandGridView should have a vertical scrollbar

  Horizontal sliders have no use in vertical only widget

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=68d1b23be84009e11f4a0dd97a9818f342b9c4d1
---

 modules/gui/qt/qml/mediacenter/MCVideoDisplay.qml     | 1 -
 modules/gui/qt/qml/mediacenter/MusicAlbumsDisplay.qml | 1 -
 modules/gui/qt/qml/utils/ExpandGridView.qml           | 8 +++-----
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/modules/gui/qt/qml/mediacenter/MCVideoDisplay.qml b/modules/gui/qt/qml/mediacenter/MCVideoDisplay.qml
index bb70683f56..1f71a3ea1b 100644
--- a/modules/gui/qt/qml/mediacenter/MCVideoDisplay.qml
+++ b/modules/gui/qt/qml/mediacenter/MCVideoDisplay.qml
@@ -315,7 +315,6 @@ Utils.NavigableFocusScope {
 
                         activeFocusOnTab:true
                         anchors.fill: parent
-                        flickableDirection:  Flickable.VerticalFlick
                         model: videosDelegate
                         modelCount: videosDelegate.items.count
 
diff --git a/modules/gui/qt/qml/mediacenter/MusicAlbumsDisplay.qml b/modules/gui/qt/qml/mediacenter/MusicAlbumsDisplay.qml
index f65a28797c..7969f945d3 100644
--- a/modules/gui/qt/qml/mediacenter/MusicAlbumsDisplay.qml
+++ b/modules/gui/qt/qml/mediacenter/MusicAlbumsDisplay.qml
@@ -112,7 +112,6 @@ Utils.NavigableFocusScope {
             id: gridView_id
 
             activeFocusOnTab:true
-            flickableDirection: Flickable.VerticalFlick
 
             cellWidth: VLCStyle.cover_normal + VLCStyle.margin_small
             cellHeight: VLCStyle.cover_normal + VLCStyle.fontHeight_normal * 2
diff --git a/modules/gui/qt/qml/utils/ExpandGridView.qml b/modules/gui/qt/qml/utils/ExpandGridView.qml
index e1851c629d..6de157c294 100644
--- a/modules/gui/qt/qml/utils/ExpandGridView.qml
+++ b/modules/gui/qt/qml/utils/ExpandGridView.qml
@@ -40,7 +40,6 @@ NavigableFocusScope {
     property alias contentX: flickable.contentX
     property bool isSingleRow: false
     property bool isAnimating: animateRetractItem.running || animateExpandItem.running
-    property alias flickableDirection: flickable.flickableDirection
 
     /// the id of the item to be expanded
     property int _expandIndex: -1
@@ -89,10 +88,9 @@ NavigableFocusScope {
     Flickable {
         id: flickable
         clip: true
-        ScrollBar.horizontal: ScrollBar{
-            anchors.bottom: flickable.bottom
-            anchors.left: flickable.left
-        }
+
+        flickableDirection: Flickable.VerticalFlick
+        ScrollBar.vertical: ScrollBar { }
 
         Loader {
             id: headerItemLoader