[vlc-commits] qml: fix miniplayer invisible on page reload bug

Fatih Uzunoglu git at videolan.org
Thu Aug 27 12:45:10 CEST 2020


vlc | branch: master | Fatih Uzunoglu <fuzun54 at outlook.com> | Wed Aug 12 23:41:45 2020 +0300| [f6547c9b128bcc3c3617939e627a59feef26a483] | committer: Pierre Lamot

qml: fix miniplayer invisible on page reload bug

Signed-off-by: Pierre Lamot <pierre at videolabs.io>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f6547c9b128bcc3c3617939e627a59feef26a483
---

 modules/gui/qt/player/qml/MiniPlayer.qml | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/modules/gui/qt/player/qml/MiniPlayer.qml b/modules/gui/qt/player/qml/MiniPlayer.qml
index 4eadaf4926..377dee6260 100644
--- a/modules/gui/qt/player/qml/MiniPlayer.qml
+++ b/modules/gui/qt/player/qml/MiniPlayer.qml
@@ -17,11 +17,9 @@ Widgets.NavigableFocusScope {
 
     property var mainContent: undefined
 
-    Component.onCompleted : {
-        if (player.playingState === PlayerController.PLAYING_STATE_STOPPED)
-            root.implicitHeight = 0;
-        else
-            root.implicitHeight = root.childrenRect.height;
+    Component.onCompleted: {
+        if (player.playingState !== PlayerController.PLAYING_STATE_STOPPED)
+            root.implicitHeight = VLCStyle.miniPlayerHeight
     }
 
     Connections {
@@ -40,7 +38,7 @@ Widgets.NavigableFocusScope {
         properties: "implicitHeight"
         duration: 200
         easing.type: Easing.InSine
-        to: root.childrenRect.height
+        to: VLCStyle.miniPlayerHeight
     }
 
     PropertyAnimation {



More information about the vlc-commits mailing list