[vlc-commits] vlc_list: Don't initialize return value with a compound literal in C++

Hugo Beauzée-Luyssen git at videolan.org
Fri Dec 4 10:43:30 UTC 2020


vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Thu Dec  3 03:27:37 2020 -0800| [7180df7a4407c30f2e102ce8e0ba63f5b098fec6] | committer: Hugo Beauzée-Luyssen

vlc_list: Don't initialize return value with a compound literal in C++

This isn't standard C++ and fails to build with MSVC

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=7180df7a4407c30f2e102ce8e0ba63f5b098fec6
---

 include/vlc_list.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/vlc_list.h b/include/vlc_list.h
index bdd70e3044..b805ab5bf1 100644
--- a/include/vlc_list.h
+++ b/include/vlc_list.h
@@ -213,7 +213,8 @@ struct vlc_list_it vlc_list_it_start(const struct vlc_list *head)
 {
     struct vlc_list *first = head->next;
 
-    return (struct vlc_list_it){ head, first, first->next };
+    struct vlc_list_it it = { head, first, first->next };
+    return it;
 }
 
 static inline bool vlc_list_it_continue(const struct vlc_list_it *restrict it)



More information about the vlc-commits mailing list