[vlc-commits] gst: do not handle impossible error

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Fri Dec  4 17:38:42 2020 +0200| [88f3b319d3b8e1ae86e4fc889d8f9d3899e18e27] | committer: Rémi Denis-Courmont

gst: do not handle impossible error

Sorting a glib list cannot fail. A NULL result means the list was
empty, not that an error occurred.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=88f3b319d3b8e1ae86e4fc889d8f9d3899e18e27
---

 modules/codec/gstreamer/gstdecode.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/modules/codec/gstreamer/gstdecode.c b/modules/codec/gstreamer/gstdecode.c
index 020bc9ded6..b57464d4a5 100644
--- a/modules/codec/gstreamer/gstdecode.c
+++ b/modules/codec/gstreamer/gstdecode.c
@@ -502,8 +502,6 @@ static int OpenDecoder( vlc_object_t *p_this )
         GList *p_l;
         /* Sort them as per ranks */
         p_list = g_list_sort( p_list, gst_plugin_feature_rank_compare_func );
-        VLC_GST_CHECK( p_list, NULL, "failed to sort decoders list",
-                VLC_ENOMOD );
         p_l = g_list_find_custom( p_list, &caps, find_decoder_func );
         VLC_GST_CHECK( p_l, NULL, "no suitable decoder found",
                 VLC_ENOMOD );