[vlc-commits] qml: fix miniplayer widget stacking

Fatih Uzunoglu git at videolan.org
Mon Dec 7 10:08:29 UTC 2020


vlc | branch: master | Fatih Uzunoglu <fuzun54 at outlook.com> | Fri Dec  4 02:01:47 2020 +0300| [bd92666f92498cdb86e7df7f374aa8677835d17e] | committer: Pierre Lamot

qml: fix miniplayer widget stacking

this patch fixes volume tooltip getting placed under the progressbar

Signed-off-by: Pierre Lamot <pierre at videolabs.io>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=bd92666f92498cdb86e7df7f374aa8677835d17e
---

 modules/gui/qt/player/qml/MiniPlayer.qml | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/modules/gui/qt/player/qml/MiniPlayer.qml b/modules/gui/qt/player/qml/MiniPlayer.qml
index 977e7ef96a..f717361c4d 100644
--- a/modules/gui/qt/player/qml/MiniPlayer.qml
+++ b/modules/gui/qt/player/qml/MiniPlayer.qml
@@ -63,17 +63,24 @@ Widgets.NavigableFocusScope {
         acceptedButtons: Qt.AllButtons
     }
 
+    Widgets.FrostedGlassEffect {
+        anchors.fill: column
+
+        source: mainContent
+        sourceRect: Qt.rect(root.x, root.y, root.width, root.height)
+
+        tint: VLCStyle.colors.blendColors(VLCStyle.colors.bg, VLCStyle.colors.banner, 0.85)
+    }
+
     Column {
+        id: column
         anchors.left: parent.left
         anchors.right: parent.right
 
-        spacing: VLCStyle.dp(-progressBar.height / 2, VLCStyle.scale)
-
         SliderBar {
             id: progressBar
             value: player.position
             visible: progressBar.value >= 0.0 && progressBar.value <= 1.0
-            z: 1
 
             isMiniplayer: true
 
@@ -86,7 +93,6 @@ Widgets.NavigableFocusScope {
             Keys.onUpPressed: root.navigationUpItem.focus = true
         }
 
-
         Item {
             id: mainRect
 
@@ -94,17 +100,8 @@ Widgets.NavigableFocusScope {
                 left: parent.left
                 right: parent.right
             }
-            z: 0
-            height: VLCStyle.miniPlayerHeight
-
-            Widgets.FrostedGlassEffect {
-                anchors.fill: parent
-
-                source: mainContent
-                sourceRect: Qt.rect(root.x, root.y, root.width, root.height)
 
-                tint: VLCStyle.colors.blendColors(VLCStyle.colors.bg, VLCStyle.colors.banner, 0.85)
-            }
+            height: VLCStyle.miniPlayerHeight
 
             PlayerButtonsLayout {
                 id: buttonsLayout



More information about the vlc-commits mailing list