[vlc-commits] qml: remove unused highlight properties from table view

Prince Gupta git at videolan.org
Thu Dec 17 14:57:03 UTC 2020


vlc | branch: master | Prince Gupta <guptaprince8832 at gmail.com> | Wed Nov  4 19:00:52 2020 +0530| [3c7281dd2774dce81e0a06e3f733f7feb831e15b] | committer: Pierre Lamot

qml: remove unused highlight properties from table view

we separately implement highlight rect for each item and this was causing unexpected scrolling when user clicks any item in view

Signed-off-by: Pierre Lamot <pierre at videolabs.io>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3c7281dd2774dce81e0a06e3f733f7feb831e15b
---

 modules/gui/qt/widgets/qml/KeyNavigableListView.qml | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/modules/gui/qt/widgets/qml/KeyNavigableListView.qml b/modules/gui/qt/widgets/qml/KeyNavigableListView.qml
index fa506e7eef..80d92528d2 100644
--- a/modules/gui/qt/widgets/qml/KeyNavigableListView.qml
+++ b/modules/gui/qt/widgets/qml/KeyNavigableListView.qml
@@ -131,14 +131,6 @@ NavigableFocusScope {
         //key navigation is reimplemented for item selection
         keyNavigationEnabled: false
 
-        preferredHighlightBegin : (view.orientation === ListView.Vertical)
-                                    ? highlightMargin + (headerItem ? headerItem.height : 0)
-                                    : highlightMargin
-        preferredHighlightEnd : (view.orientation === ListView.Vertical)
-                                    ? height - highlightMargin
-                                    : width - highlightMargin
-        highlightRangeMode: ListView.ApplyRange
-
         focus: true
 
         clip: true



More information about the vlc-commits mailing list