[vlc-commits] mmal: remove unused cma_vcsm_type

Steve Lhomme git at videolan.org
Fri Jan 24 14:15:50 CET 2020


vlc | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Fri Jan 24 12:26:48 2020 +0100| [da03125578c5c975b8c5f6eabf86b92d52827c4d] | committer: Steve Lhomme

mmal: remove unused cma_vcsm_type

global variables are evil

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=da03125578c5c975b8c5f6eabf86b92d52827c4d
---

 modules/hw/mmal/mmal_picture.c | 5 -----
 modules/hw/mmal/mmal_picture.h | 1 -
 2 files changed, 6 deletions(-)

diff --git a/modules/hw/mmal/mmal_picture.c b/modules/hw/mmal/mmal_picture.c
index abc305e5aa..ab289246f2 100644
--- a/modules/hw/mmal/mmal_picture.c
+++ b/modules/hw/mmal/mmal_picture.c
@@ -1210,11 +1210,6 @@ bool rpi_is_model_pi4(void) {
 // Preferred mode - none->cma on Pi4 otherwise legacy
 static volatile vcsm_init_type_t last_vcsm_type = VCSM_INIT_NONE;
 
-vcsm_init_type_t cma_vcsm_type(void)
-{
-    return last_vcsm_type;
-}
-
 vcsm_init_type_t cma_vcsm_init(void)
 {
     vcsm_init_type_t rv = VCSM_INIT_NONE;
diff --git a/modules/hw/mmal/mmal_picture.h b/modules/hw/mmal/mmal_picture.h
index eaf9c07e7a..7e9f9ca3b3 100644
--- a/modules/hw/mmal/mmal_picture.h
+++ b/modules/hw/mmal/mmal_picture.h
@@ -168,7 +168,6 @@ typedef enum vcsm_init_type_e {
 
 vcsm_init_type_t cma_vcsm_init(void);
 void cma_vcsm_exit(const vcsm_init_type_t init_mode);
-vcsm_init_type_t cma_vcsm_type(void);
 const char * cma_vcsm_init_str(const vcsm_init_type_t init_mode);
 
 #define MMAL_RESIZE_NAME "mmal-resize"



More information about the vlc-commits mailing list