[vlc-commits] demux: use noinst_* for the mock module

Thomas Guillem git at videolan.org
Thu Jun 4 13:51:51 CEST 2020


vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Thu May 28 13:49:10 2020 +0200| [efb54cb748b4b837c383cce2d29d78dd71891eb9] | committer: Thomas Guillem

demux: use noinst_* for the mock module

>From RĂ©mi:
"Test plugins should use noinst_*, IMO. With check_*, you would end up with
stale plugins and potentially weird crashes due to ABI breaks if alternating
make all and make check."

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=efb54cb748b4b837c383cce2d29d78dd71891eb9
---

 modules/demux/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/demux/Makefile.am b/modules/demux/Makefile.am
index 1f6d2ff7a3..67ec086af9 100644
--- a/modules/demux/Makefile.am
+++ b/modules/demux/Makefile.am
@@ -509,4 +509,4 @@ demux_LTLIBRARIES += libnoseek_plugin.la
 
 libdemux_mock_plugin_la_SOURCES = demux/mock.c
 libdemux_mock_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(demuxdir)'
-check_LTLIBRARIES += libdemux_mock_plugin.la
+noinst_LTLIBRARIES += libdemux_mock_plugin.la



More information about the vlc-commits mailing list