[vlc-commits] qt: fix uninitialized variables in DComp compositor

Pierre Lamot git at videolan.org
Fri Jun 19 09:54:13 CEST 2020


vlc | branch: master | Pierre Lamot <pierre at videolabs.io> | Thu Jun 11 17:04:14 2020 +0200| [d7abbd01c86ce86239f4aeb4398619dd54c5f47e] | committer: Pierre Lamot

qt: fix uninitialized variables in DComp compositor

  This was causing crashes when releasing the object after a failed init.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d7abbd01c86ce86239f4aeb4398619dd54c5f47e
---

 modules/gui/qt/maininterface/compositor_dcomp.hpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/gui/qt/maininterface/compositor_dcomp.hpp b/modules/gui/qt/maininterface/compositor_dcomp.hpp
index 1d89affa9b..7deaf92127 100644
--- a/modules/gui/qt/maininterface/compositor_dcomp.hpp
+++ b/modules/gui/qt/maininterface/compositor_dcomp.hpp
@@ -59,9 +59,9 @@ private:
     static void window_unset_fullscreen(struct vout_window_t *);
     static void window_set_fullscreen(struct vout_window_t *, const char *id);
 
-    intf_thread_t *m_intf;
+    intf_thread_t *m_intf = nullptr;
 
-    MainInterface* m_rootWindow;
+    MainInterface* m_rootWindow = nullptr;
     std::unique_ptr<CompositorDCompositionUISurface> m_uiSurface;
     vout_window_t *m_window = nullptr;
     std::unique_ptr<MainUI> m_ui;



More information about the vlc-commits mailing list